build: shared OpenSSL dylibs to deduplicate across main app and plugins#898
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0d9329fb2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # --- OpenSSL shared dylibs --- | ||
| echo "Creating OpenSSL shared dylibs for local development..." | ||
| if [[ -f "$LIBS_DIR/libcrypto_arm64.a" || -f "$LIBS_DIR/libcrypto.a" ]]; then | ||
| scripts/create-openssl-dylibs.sh both |
There was a problem hiding this comment.
This new dylib step only runs in the fresh-download path, but download-libs.sh exits early when Libs/.downloaded or existing *.a files are present. On machines that already had libraries before this commit, rerunning the script will skip this block and never create Libs/dylibs/libssl.3.dylib/libcrypto.3.dylib, so Xcode link steps that now require -lssl.3 and -lcrypto.3 fail until the user runs the new script manually.
Useful? React with 👍 / 👎.
1 participant
Summary
Contents/Frameworks/instead of 6 embedded copies.scripts/create-openssl-dylibs.shconverts static.ato.dylibwith@rpathinstall namesbuild-release.shcreates arch-specific dylibs before build and embeds them in Frameworksdownload-libs.shcreates universal dylibs after downloading static libs for local devTest plan
scripts/create-openssl-dylibs.sh bothand verify dylibs created inLibs/dylibs/otool -Lshows@rpath/libssl.3.dylibon main binary and all pluginsscripts/build-release.sh arm64- verify dylibs embedded inContents/Frameworks/